Adding package exporting injection tokens for cluster settings #7395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
ixrock
previously approved these changes
Mar 22, 2023
| "generate-types": "tsc --d --declarationDir ./dist --declarationMap --emitDeclarationOnly", | ||
| "build": "npm run generate-types && swc ./src/index.ts -d ./dist" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
Should we include typescript as dev dependency as well?
There was a problem hiding this comment.
Not sure. It works well without specify typescript here. Probably it uses some globally installed typescript somehow.
There was a problem hiding this comment.
Yes, try to remove global ‘typescript’ package and check again.
packages/core/src/renderer/components/cluster-settings/__tests__/icon-settings.test.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/renderer/components/cluster-settings/__tests__/icon-settings.test.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Nokel81
reviewed
Mar 22, 2023
| @@ -0,0 +1,31 @@ | |||
| { | |||
| "name": "@k8slens/cluster-settings", | |||
| "version": "6.5.0-alpha.1", | |||
There was a problem hiding this comment.
Nit: this should probably be 1.0.0-alpha.1
There was a problem hiding this comment.
Following same versioning as other internal packages. Keeping 6.5.0-alpha.1 for now until clarification. Will change it if needed in follow up PR.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third part of #3846. Second part is #7365.
Adding
cluster-settingsinner package which exports injection tokens needed for cluster settings icon configuration.